Issue28677
Created on 2016-11-12 21:32 by viorel, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 6208 | merged | Aaron Ang, 2018-03-24 06:48 | |
| PR 8461 | merged | miss-islington, 2018-07-25 14:21 | |
| PR 8462 | merged | miss-islington, 2018-07-25 14:22 | |
| PR 8469 | merged | miss-islington, 2018-07-25 17:32 | |
| Messages (9) | |||
|---|---|---|---|
| msg280671 - (view) | Author: Viorel Tabara (viorel) | Date: 2016-11-12 21:32 | |
Method objects are explained at:
https://docs.python.org/3/tutorial/classes.html#method-objects
I'd like to suggest a change from:
When an instance attribute is referenced that isn’t a data attribute, its
class is searched.
to something along this line:
When an instance attribute --- that isn’t a data attribute --- is
referenced, the instance parent class will be searched.
|
|||
| msg280702 - (view) | Author: R. David Murray (r.david.murray) *  |
Date: 2016-11-13 16:43 | |
"instance parent class" is not terminology used in our docs as far as I remember. "instance's class" would be more in line with the other docs. That would solve the pronoun reference problem more succinctly, I think. How about this version, which also improves the awkward phrasing, but without using em-dashes: "When a non-data attribute of an instance is referenced, the instance's class is searched." |
|||
| msg280708 - (view) | Author: Viorel Tabara (viorel) | Date: 2016-11-13 19:14 | |
David, that sounds clear enough to me, thanks. However, English isn't my first language so I can't comment on the grammatical subtleties. |
|||
| msg281151 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2016-11-18 17:38 | |
David's wording looks good. |
|||
| msg322355 - (view) | Author: Tal Einat (taleinat) * |
Date: 2018-07-25 14:21 | |
New changeset c0f0a7669c73c0d444851dd4c5299de2479214cc by Tal Einat (Aaron Ang) in branch 'master': bpo-28677: Improve phrasing of when instance attribute is referenced (GH-6208) https://github.com/python/cpython/commit/c0f0a7669c73c0d444851dd4c5299de2479214cc |
|||
| msg322374 - (view) | Author: miss-islington (miss-islington) | Date: 2018-07-25 17:40 | |
New changeset 1c8f6553ad5a7f97495972da8f35f4dabcb372d4 by Miss Islington (bot) in branch '2.7': bpo-28677: Improve phrasing of when instance attribute is referenced (GH-6208) https://github.com/python/cpython/commit/1c8f6553ad5a7f97495972da8f35f4dabcb372d4 |
|||
| msg322375 - (view) | Author: miss-islington (miss-islington) | Date: 2018-07-25 17:40 | |
New changeset cfadd1c2421e13d76d588982147d4fbdc71d5527 by Miss Islington (bot) in branch '3.6': bpo-28677: Improve phrasing of when instance attribute is referenced (GH-6208) https://github.com/python/cpython/commit/cfadd1c2421e13d76d588982147d4fbdc71d5527 |
|||
| msg322377 - (view) | Author: Tal Einat (taleinat) * |
Date: 2018-07-25 17:52 | |
New changeset ec02c58f5a6fdb06b769f53255fcb5d393812160 by Tal Einat (Miss Islington (bot)) in branch '3.7': bpo-28677: Improve phrasing of when instance attribute is referenced (GH-6208) https://github.com/python/cpython/commit/ec02c58f5a6fdb06b769f53255fcb5d393812160 |
|||
| msg322378 - (view) | Author: Tal Einat (taleinat) * |
Date: 2018-07-25 17:53 | |
Thanks for the PR, Aaron! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:39 | admin | set | github: 72863 |
| 2018-07-25 17:53:04 | taleinat | set | status: open -> closed versions: + Python 2.7, Python 3.6 messages: + msg322378 resolution: fixed |
| 2018-07-25 17:52:21 | taleinat | set | messages: + msg322377 |
| 2018-07-25 17:40:36 | miss-islington | set | messages: + msg322375 |
| 2018-07-25 17:40:13 | miss-islington | set | nosy:
+ miss-islington messages: + msg322374 |
| 2018-07-25 17:32:48 | miss-islington | set | pull_requests: + pull_request7993 |
| 2018-07-25 14:22:47 | miss-islington | set | pull_requests: + pull_request7986 |
| 2018-07-25 14:21:54 | miss-islington | set | pull_requests: + pull_request7985 |
| 2018-07-25 14:21:36 | taleinat | set | nosy:
+ taleinat messages: + msg322355 |
| 2018-03-24 06:48:53 | Aaron Ang | set | keywords:
+ patch stage: needs patch -> patch review pull_requests: + pull_request5952 |
| 2018-03-21 20:33:53 | steven.downum | set | nosy:
+ steven.downum |
| 2018-03-15 17:50:06 | cheryl.sabella | set | keywords:
+ easy stage: needs patch versions: + Python 3.7, Python 3.8 |
| 2016-11-18 17:38:57 | terry.reedy | set | nosy:
+ terry.reedy messages: + msg281151 |
| 2016-11-13 19:14:21 | viorel | set | messages: + msg280708 |
| 2016-11-13 16:43:01 | r.david.murray | set | nosy:
+ r.david.murray messages: + msg280702 |
| 2016-11-12 21:32:17 | viorel | create | |