The documentation of the dis module says that:

  CALL_FUNCTION_VAR (argc)

   Calls a function. *argc* is interpreted as in CALL_FUNCTION. The
   top elements on the stack are the keyword arguments, followed by the
   variable argument list, and then the positional arguments.

However, inspecting the how ``f(b=1, *args)`` is actually compiled shows a different order:

   >>> import dis
   >>> dis.dis(compile('f(b=1, *args)', '<>', 'eval'))

  1           0 LOAD_NAME                0 (f)
              3 LOAD_NAME                1 (args)
              6 LOAD_CONST               0 ('b')
              9 LOAD_CONST               1 (1)
             12 CALL_FUNCTION_VAR      256 (0 positional, 1 keyword pair)
             15 RETURN_VALUE

Notice that the top of the stack contains the explicit keyword arguments.

The documentation of CALL_FUNCTION_VAR_KW is also incorrect.

Correction, the documentation for CALL_FUNCTION_VAR said:

Calls a function. *argc* is interpreted as in :opcode:`CALL_FUNCTION`. The top element on the stack contains the variable argument list, followed by keyword and positional arguments.


In a previous comment I pasted the version I'm putting in the PR.

I confirm that this issue is 3.5-only. Before 3.5 the order matched the documentation. After 3.5 these opcodes were completely rewritten and they use now other way of passing arguments.

Serhiy, why did you mark this as a release blocker?  This is a proposed documentation fix.

If the issue is specific to Python 3.5, we can no longer fix it since 3.5 doesn't accept bugfixes anymore. No?

Documentation changes are okay.

Because I don't want that this fix be missed in the next bugfix release. I think this documentation is important enough. There may be no chance to document it later.

Marking an issue as "Release Blocker" is completely inappropriate for "I'd like to see this documentation change get into the next bugfix release."

Our Python Dev Guide discusses priority, here:

https://devguide.python.org/triaging/#priority

It says:

"As a guideline, critical and above are usually reserved for crashes, serious regressions or breakage of very important APIs. Whether a bug is a release blocker for the current release schedule is decided by the release manager. Triagers may recommend this priority and should add the release manager to the nosy list. If needed, consult the release schedule and the release’s associated PEP for the release manager’s name."


Please do not mark any bugs as "Release Blocker" in the future unless you are the release manager for that version.

Sorry. I have attracted your attention, and this was the only purpose of this mark. You are aware of this issue now, and the further fate of it is up to you.

New changeset 76aa2c0a9a8dd3ac90b91e7342c8ce8125bf21f9 by larryhastings in branch '3.5':
bpo-33216: Clarify the documentation for CALL_FUNCTION_* (#8338)
https://github.com/python/cpython/commit/76aa2c0a9a8dd3ac90b91e7342c8ce8125bf21f9

FTR, the change was introduced by the PEP 448 implementation. [1]

[1] https://github.com/python/cpython/pull/8338#issuecomment-406256152

FYI, I opened bpo-34413 to address how the bytecode change is not mentioned in the porting section of the 3.5 "What's New" doc.  In retrospect (I didn't notice that this issue was still open), I suppose that doesn't need a separate issue so feel free to close #34413 in favor of this one. :)

New changeset 5e99b56d6b249995a4fa2bc09c0bb03841f49572 by Serhiy Storchaka in branch 'master':
bpo-33216: Improve the documentation for CALL_FUNCTION_* (GH-8338) (GH-8784)
https://github.com/python/cpython/commit/5e99b56d6b249995a4fa2bc09c0bb03841f49572

New changeset afa591d7748c66831e6e650108024f3293be33f1 by Serhiy Storchaka in branch '2.7':
[2.7] bpo-33216: Clarify the documentation for CALL_FUNCTION_* (GH-8338) (GH-8783)
https://github.com/python/cpython/commit/afa591d7748c66831e6e650108024f3293be33f1

Thank you Larry for your rewriting.

New changeset f8e34eee74871b3343f6c3545bce41242ba378e8 by Miss Islington (bot) in branch '3.7':
bpo-33216: Improve the documentation for CALL_FUNCTION_* (GH-8338) (GH-8784)
https://github.com/python/cpython/commit/f8e34eee74871b3343f6c3545bce41242ba378e8

New changeset 1e7193bd027a5a4aa1a387e3f201a3e465c25f01 by Miss Islington (bot) in branch '3.6':
bpo-33216: Improve the documentation for CALL_FUNCTION_* (GH-8338) (GH-8784)
https://github.com/python/cpython/commit/1e7193bd027a5a4aa1a387e3f201a3e465c25f01

stage: patch review -> resolved

messages: + msg317473

nosy: - ned.deily

components: + Documentation
versions: + Python 3.5
nosy: + docs@python
title: CALL_FUNCTION_VAR -> Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW
messages: + msg314888