fix(DanaKit): prevent app crash during pump deletion by bastiaanv · Pull Request #308 · LoopKit/LoopWorkspace
Navigation Menu
{{ message }}
LoopKit / LoopWorkspace Public
- Notifications You must be signed in to change notification settings
- Fork 7.5k
Merged
marionbarker merged 1 commit intoLoopKit:feat/danafrom
Aug 12, 2025Merged
fix(DanaKit): prevent app crash during pump deletion#308
marionbarker merged 1 commit intoLoopKit:feat/danafrom
fix(DanaKit): prevent app crash during pump deletion#308
marionbarker merged 1 commit intoLoopKit:feat/danafrom
Conversation
Copy link
Contributor
bastiaanv
commented
Aug 12, 2025
bastiaanv
commented
The app crash was caused by Loop trying to dismiss a UI element without running on the main thread.
Simple fix was implemented to move the code to the main thread before running: completionDelegate.completionNotifyingDidComplete(self)
marionbarker approved these changes Aug 12, 2025
Copy link
Contributor
marionbarker
left a comment
marionbarker
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. I confirmed this works as expected when adding and removing a Dana pump using the Dana simulator.
marionbarker
merged commit
310263e
into
LoopKit:feat/dana
marionbarker
mentioned this pull request
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants