[MTT-8705] Upgrade Client Driven Sample to Unity 6 by FabianStoll · Pull Request #259 · Unity-Technologies/com.unity.multiplayer.samples.bitesize

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@FabianStoll

Copy link Copy Markdown

Contributor

@FabianStoll FabianStoll commented

Nov 22, 2024

edited

Loading

Description

This PR is for upgrading the Client Driven Sample to Unity 6.
It also replaces ParrelSync with MPPM and fixes any warnings that pop up during startup.

Issue Number(s)

MTT-8705

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@unity-cla-assistant

Copy link Copy Markdown

unity-cla-assistant commented

Nov 22, 2024

edited

Loading

CLA assistant check
All committers have signed the CLA.

@FabianStoll FabianStoll changed the base branch from main to develop

November 22, 2024 14:54

@FabianStoll FabianStoll marked this pull request as ready for review

November 22, 2024 15:27

@FabianStoll FabianStoll requested a review from a team as a code owner

November 22, 2024 15:27

@FabianStoll FabianStoll marked this pull request as draft

November 22, 2024 15:58

@FabianStoll FabianStoll marked this pull request as ready for review

November 25, 2024 10:17
Copy link Copy Markdown

Contributor

@Elfi0Kuhndorf Elfi0Kuhndorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I also tested in the editor with multiple MPPM windows and it worked all as expected.

FabianStoll reacted with hooray emoji

@FabianStoll FabianStoll enabled auto-merge (squash)

November 27, 2024 16:12

@FabianStoll FabianStoll merged commit 6949467 into develop

Nov 27, 2024

@FabianStoll FabianStoll deleted the feat/client-driven/unity-6-upgrade branch

November 27, 2024 16:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Elfi0Kuhndorf Elfi0Kuhndorf Elfi0Kuhndorf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FabianStoll @unity-cla-assistant @Elfi0Kuhndorf