feat: dynamic prefabs UI integration by fernando-cortez · Pull Request #98 · Unity-Technologies/com.unity.multiplayer.samples.bitesize
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 134
Merged
fernando-cortez merged 15 commits intodevelopfrom
Feb 16, 2023Merged
feat: dynamic prefabs UI integration#98
fernando-cortez merged 15 commits intodevelopfrom
feat: dynamic prefabs UI integration#98
fernando-cortez merged 15 commits intodevelopfrom
Conversation
Copy link Copy Markdown
Contributor
fernando-cortez
commented
Feb 16, 2023
fernando-cortez
commented
Description
PR for integration of DynamicAddressableNetworkPrefabs with UI overhaul.
Issue Number(s)
N/A
Contribution checklist
- Tests have been added for the project and/or any internal package
- Release notes have been added to the project changelog file
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- JIRA ticket ID is in the PR title or at least one commit message
- Include the ticket ID number within the body message of the PR to create a hyperlink
fernando-cortez added 10 commits
February 15, 2023 16:02…y status on server
fernando-cortez
assigned
LPLafontaineB
fernando-cortez
requested a review
from jilfranco-unity
fernando-cortez and others added 2 commits
February 16, 2023 11:21
fernando-cortez
requested a review
from SamuelBellomo
fernando-cortez
requested a review
from LPLafontaineB
...abs/Assets/Scripts/02_Server Authoritative Load All Async/ServerAuthoritativeLoadAllAsync.cs
Outdated
Show resolved
Hide resolved
...abs/Assets/Scripts/02_Server Authoritative Load All Async/ServerAuthoritativeLoadAllAsync.cs Outdated Show resolved Hide resolved
...ripts/03_Server Authoritative Synchronous Spawning/ServerAuthoritativeSynchronousSpawning.cs
Outdated
Show resolved
Hide resolved
...ripts/03_Server Authoritative Synchronous Spawning/ServerAuthoritativeSynchronousSpawning.cs Outdated Show resolved Hide resolved
...er Authoritative Network-Visibility Spawning/ServerAuthoritativeNetworkVisibilitySpawning.cs
Outdated
Show resolved
Hide resolved
...er Authoritative Network-Visibility Spawning/ServerAuthoritativeNetworkVisibilitySpawning.cs Outdated Show resolved Hide resolved
Basic/DynamicAddressablesNetworkPrefabs/Assets/Scripts/05_API Playground/APIPlayground.cs
Outdated
Show resolved
Hide resolved
Basic/DynamicAddressablesNetworkPrefabs/Assets/Scripts/05_API Playground/APIPlayground.cs Outdated Show resolved Hide resolved
Basic/DynamicAddressablesNetworkPrefabs/Assets/Scripts/Shared/AppController.cs
Outdated
Show resolved
Hide resolved
Basic/DynamicAddressablesNetworkPrefabs/Assets/Scripts/Shared/AppController.cs Outdated Show resolved Hide resolved
Basic/DynamicAddressablesNetworkPrefabs/Assets/Scripts/UI/InGameUI.cs
Outdated
Show resolved
Hide resolved
Basic/DynamicAddressablesNetworkPrefabs/Assets/Scripts/UI/InGameUI.cs Outdated Show resolved Hide resolved
Copy link Copy Markdown
Contributor
LPLafontaineB
left a comment
LPLafontaineB
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from nitpicks, lgtm
SamuelBellomo approved these changes Feb 16, 2023
Copy link Copy Markdown
Contributor
SamuelBellomo
left a comment
SamuelBellomo
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-approving while you're fixing the string in rpc comments. Feel free to merge once that fix is in
fernando-cortez added 2 commits
February 16, 2023 16:33
fernando-cortez
merged commit
289635b
into
develop
fernando-cortez
deleted the
feat/dynamic-prefabs-UI-integration
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment