chore: ClientCharacter TODO cleanup on anticipation [MTT-1744] by fernando-cortez · Pull Request #786 · Unity-Technologies/com.unity.multiplayer.samples.coop
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 588
Merged
chore: ClientCharacter TODO cleanup on anticipation [MTT-1744]#786
fernando-cortez merged 6 commits intodevelopfrom
chore: ClientCharacter TODO cleanup on anticipation [MTT-1744]#786
fernando-cortez merged 6 commits intodevelopfrom
Conversation
Copy link Copy Markdown
Contributor
fernando-cortez
commented
Nov 15, 2022
fernando-cortez
commented
Description
Quick PR to cleanup a TODO in code. ClientCharacter's action input anticipation chunk of code should still only execute on owning, client characters.
Issue Number(s)
Contribution checklist
- Tests have been added for boss room and/or utilities pack
- Release notes have been added to the project changelog file and/or package changelog file
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- JIRA ticket ID is in the PR title or at least one commit message
- Include the ticket ID number within the body message of the PR to create a hyperlink
- An Index entry has been added in readme.md if applicable
fernando-cortez
added
2-Easy
labels
Nov 15, 2022
fernando-cortez
requested a review
from SamuelBellomo
as a code owner
fernando-cortez
assigned
SamuelBellomo
Assets/Scripts/Gameplay/GameplayObjects/Character/ClientCharacter.cs
Outdated
Show resolved
Hide resolved
Assets/Scripts/Gameplay/GameplayObjects/Character/ClientCharacter.cs Outdated Show resolved Hide resolved
fernando-cortez added 2 commits
December 15, 2022 15:29fernando-cortez added 2 commits
December 15, 2022 15:45
fernando-cortez
requested a review
from SamuelBellomo
SamuelBellomo approved these changes Dec 16, 2022
fernando-cortez
merged commit
3b391ef
into
develop
fernando-cortez
deleted the
chore/clientcharacter-cleanup
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants