Contributor

Description

This PR uses the ConnectionMethod to simplify the reconnection flow. Now ClientReconnectingState doesn't need to know if the client was connected through Lobby or Direct IP before attempting to reconnect and instead offloads that responsibility to the ConnectionMethod that it was initially configured with. This also adds the possibility to fail early and stop retrying to reconnect if the lobby doesn't exist anymore.

Issue Number(s)

None

Contribution checklist

• [n/a] Tests have been added for boss room and/or utilities pack
• Release notes have been added to the project changelog file and/or package changelog file
• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• [n/a] JIRA ticket ID is in the PR title or at least one commit message
• [n/a] Include the ticket ID number within the body message of the PR to create a hyperlink
• [n/a] An Index entry has been added in readme.md if applicable

(cherry picked from commit f9d5ad9)

…ger exists

Adding comments and debug logs

bf2fe23

removing unneeded using directives

f53dd25

Moving ConnectionMethod responsibility to ConnectionManager

d5095f3

This reverts commit d5095f3.

more debug log

61c74af

removing another unneeded using directive

8d6130a

Adding changelog entry

3c235a2

coding standards

7d110dc

fernando-cortez previously approved these changes Mar 1, 2023

View reviewed changes

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fernando-cortez approved these changes Mar 6, 2023

View reviewed changes