refactor: replacing custom pool implementation with ObjectPool [MTT-6263] by LPLafontaineB · Pull Request #824 · Unity-Technologies/com.unity.multiplayer.samples.coop
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 588
Merged
refactor: replacing custom pool implementation with ObjectPool [MTT-6263]#824
LPLafontaineB merged 14 commits intodevelopfrom
refactor: replacing custom pool implementation with ObjectPool [MTT-6263]#824
LPLafontaineB merged 14 commits intodevelopfrom
Conversation
Copy link Copy Markdown
Contributor
Description
This PR replaces our custom pool implementation using queues with the ObjectPool collection. It also removes the methods InitializePool and ClearPool and moves their content in OnNetworkSpawn and OnNetworkDespawn
Issue Number(s)
Contribution checklist
- [n/a] Tests have been added for boss room and/or utilities pack
- Release notes have been added to the project changelog file and/or package changelog file
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- JIRA ticket ID is in the PR title or at least one commit message
- Include the ticket ID number within the body message of the PR to create a hyperlink
- [n/a] An Index entry has been added in readme.md if applicable
LPLafontaineB added 6 commits
April 20, 2023 14:19
LPLafontaineB
assigned
fernando-cortez
LPLafontaineB
requested a review
from fernando-cortez
LPLafontaineB
added
1-Needs Review
labels
Apr 20, 2023LPLafontaineB added 2 commits
April 20, 2023 15:36
LPLafontaineB
marked this pull request as ready for review
LPLafontaineB
requested a review
from SamuelBellomo
as a code owner
LPLafontaineB commented Apr 20, 2023
Assets/Scripts/Infrastructure/NetworkObjectPool.cs
Show resolved
Hide resolved
Assets/Scripts/Infrastructure/NetworkObjectPool.cs Show resolved Hide resolved
LPLafontaineB added 2 commits
April 20, 2023 16:40
Assets/Scripts/Infrastructure/NetworkObjectPool.cs
Show resolved
Hide resolved
Assets/Scripts/Infrastructure/NetworkObjectPool.cs Show resolved Hide resolved
LPLafontaineB added 4 commits
April 21, 2023 11:54SamuelBellomo approved these changes Apr 21, 2023
LPLafontaineB
merged commit
512bb55
into
develop
LPLafontaineB
deleted the
fix/refactor-pool-for-native
branch
LPLafontaineB
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment