fix: decoupling SceneLoaderWrapper and ConnectionStates [MTT-6242] by LPLafontaineB · Pull Request #830 · Unity-Technologies/com.unity.multiplayer.samples.coop
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 588
Merged
fix: decoupling SceneLoaderWrapper and ConnectionStates [MTT-6242]#830
LPLafontaineB merged 7 commits intodevelopfrom
fix: decoupling SceneLoaderWrapper and ConnectionStates [MTT-6242]#830
LPLafontaineB merged 7 commits intodevelopfrom
Conversation
Copy link Copy Markdown
Contributor
Description
This PR removes SceneLoaderWrapper.AddOnSceneEventCallback and replaces it with registrations to NetworkManager OnServerStarted and OnClientStarted callbacks.
Issue Number(s)
Contribution checklist
- Tests have been added for boss room and/or utilities pack
- Release notes have been added to the project changelog file and/or package changelog file
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- JIRA ticket ID is in the PR title or at least one commit message
- Include the ticket ID number within the body message of the PR to create a hyperlink
- [n/a] An Index entry has been added in readme.md if applicable
LPLafontaineB added 3 commits
April 26, 2023 10:15…with registrations to NetworkManager callbacks
LPLafontaineB
assigned
SamuelBellomo
LPLafontaineB
requested a review
from fernando-cortez
LPLafontaineB
added
2-Easy
labels
Apr 26, 2023
LPLafontaineB
marked this pull request as ready for review
LPLafontaineB
requested a review
from SamuelBellomo
as a code owner
fernando-cortez previously approved these changes Apr 26, 2023
fernando-cortez
added
3-Good to Merge
and removed
1-Needs Review
labels
Apr 26, 2023
LPLafontaineB
dismissed
fernando-cortez’s stale review
via
b4888a1
SamuelBellomo approved these changes Apr 26, 2023
LPLafontaineB
merged commit
32f4732
into
develop
LPLafontaineB
deleted the
fix/decoupling-sceneloaderwrapper
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment