feat: profile name authentication truncating [MTT-6241] by fernando-cortez · Pull Request #831 · Unity-Technologies/com.unity.multiplayer.samples.coop

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@fernando-cortez

Copy link Copy Markdown

Contributor

@fernando-cortez fernando-cortez commented

Apr 26, 2023

edited

Loading

Description

This PR updates our profile name generation in anticipation of Authentication service's new profile name length requirements.

Issue Number(s)

MTT-6241

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@fernando-cortez fernando-cortez added 2-Easy

This PR is trivial and can be reviewed quickly

1-Needs Review

PR needs attention from the assignee and reviewers

labels

Apr 26, 2023

@fernando-cortez fernando-cortez marked this pull request as ready for review

April 26, 2023 17:31

@LPLafontaineB LPLafontaineB added 3-Good to Merge and removed 1-Needs Review

PR needs attention from the assignee and reviewers

labels

Apr 26, 2023

@fernando-cortez fernando-cortez merged commit 0c98045 into develop

Apr 26, 2023

@fernando-cortez fernando-cortez deleted the feat/profile-name-authentication-truncating branch

April 26, 2023 18:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamuelBellomo SamuelBellomo Awaiting requested review from SamuelBellomo

1 more reviewer

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

Reviewers whose approvals may not affect merge requirements

Labels

2-Easy

This PR is trivial and can be reviewed quickly

3-Good to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fernando-cortez @LPLafontaineB