fix: removing warnings on project launch [MTT-9362] by fernando-cortez · Pull Request #896 · Unity-Technologies/com.unity.multiplayer.samples.coop

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@fernando-cortez

Copy link Copy Markdown

Contributor

@fernando-cortez fernando-cortez commented

Jan 7, 2025

edited

Loading

Description

This PR resolves warning messages logged when first opening the project. This included:

  • VContainer package upgrade removes warning messages related to IL weaving as code gen is refactored in v1.14.0
  • Some asset meta files with merge conflicts resolved
  • RenderGraph compatibility mode disabled

Issue Number(s)

MTT-9362

Contribution checklist

  • [ N/A ] Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • [ N/A ] An Index entry has been added in readme.md if applicable

@fernando-cortez fernando-cortez marked this pull request as ready for review

January 7, 2025 21:07

@fernando-cortez fernando-cortez requested a review from a team as a code owner

January 7, 2025 21:07

@fernando-cortez fernando-cortez requested a review from a team as a code owner

January 13, 2025 16:35

FabianStoll

FabianStoll previously approved these changes Jan 14, 2025

Copy link Copy Markdown

Contributor

@FabianStoll FabianStoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

Base automatically changed from feat/upgrade-packages-to-recommendation to develop

January 15, 2025 18:56

@fernando-cortez fernando-cortez dismissed FabianStoll’s stale review

January 15, 2025 18:56

The base branch was changed.

@fernando-cortez fernando-cortez merged commit 4e8d8db into develop

Jan 16, 2025

@fernando-cortez fernando-cortez deleted the fix/removing-warnings branch

January 16, 2025 16:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FabianStoll FabianStoll FabianStoll approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fernando-cortez @FabianStoll