fix: name generation bounds fixed to include last item by fernando-cortez · Pull Request #922 · Unity-Technologies/com.unity.multiplayer.samples.coop
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 588
Merged
fix: name generation bounds fixed to include last item#922
fernando-cortez merged 3 commits intodevelopfrom
fix: name generation bounds fixed to include last item#922
fernando-cortez merged 3 commits intodevelopfrom
Conversation
Copy link Copy Markdown
Contributor
fernando-cortez
commented
Jul 24, 2025
fernando-cortez
commented
Description
Small PR to fix the bounds issue inside of the player name generation, where the last item in the arrays for first and last nam weren't being used.
Issue Number(s)
Contribution checklist
- Tests have been added for boss room and/or utilities pack
- Release notes have been added to the project changelog file and/or package changelog file
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- JIRA ticket ID is in the PR title or at least one commit message
- Include the ticket ID number within the body message of the PR to create a hyperlink
- An Index entry has been added in readme.md if applicable
fernando-cortez added 2 commits
July 24, 2025 15:02
fernando-cortez
marked this pull request as ready for review
fernando-cortez
requested a review
from a team
as a code owner
RikuTheFuffs approved these changes Jul 24, 2025
kalmanbalint approved these changes Jul 24, 2025
Copy link Copy Markdown
kalmanbalint
left a comment
kalmanbalint
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
fernando-cortez
deleted the
fix/name-generation
branch
fernando-cortez
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants