fix bug: get profile api cannot be accessed #1882 by wangyao2016 · Pull Request #1883 · apache/hugegraph

@wangyao2016

To solve this problem #1882, I modified the route of getprofile API as /profiles

image

@wangyao-cmss

@wangyao2016 wangyao2016 changed the title fix bud: get profile api cannot be accessed #1882 fix bug: get profile api cannot be accessed #1882

May 16, 2022

@codecov

javeme

private static String API_PROFILES = null;

@GET
@Path("profiles")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we fix this issue and keep the origin url path?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify the check rule or just change routing to "/profiles"?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out the root cause.
IMO we cam add url "/" to WHITE_API_LIST to keep the continuity.
@corgiboygsj could you please also take a look?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice that ProfileApi would use an blank url. So in order to keep the original url, I chose to delete the blank url check. #1893

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's keep the original url

@javeme

@zyxxoo Do you think this issue may be caused by upgrading jersey?

@wangyao2016