fix: fix ProfileApi url check by corgiboygsj · Pull Request #1893 · apache/hugegraph

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@corgiboygsj

Copy link

Member

@corgiboygsj corgiboygsj commented

May 27, 2022

edited

Loading

Delete blank url check, because ProfileApi has api in use "/"

@codecov

Copy link

codecov bot commented

May 27, 2022

edited

Loading

Codecov Report

Merging #1893 (af32ace) into master (88d71e7) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             master    #1893    +/-   ##
==========================================
  Coverage     66.75%   66.75%            
- Complexity      728      980   +252     
==========================================
  Files           451      451            
  Lines         38207    38206     -1     
  Branches       5407     5407            
==========================================
+ Hits          25505    25506     +1     
+ Misses        10185    10183     -2     
  Partials       2517     2517            
Impacted Files Coverage Δ
...idu/hugegraph/api/filter/AuthenticationFilter.java 55.00% <ø> (-0.45%) ⬇️
...egraph/backend/store/cassandra/CassandraShard.java 54.54% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88d71e7...af32ace. Read the comment docs.

Copy link

Contributor

@wangyao2016 wangyao2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imbajin imbajin changed the title fix bug: fix ProfileApi url check fix: fix ProfileApi url check

May 28, 2022

@imbajin imbajin merged commit 1118418 into master

May 28, 2022

@imbajin imbajin deleted the fix-api-url-check branch

May 28, 2022 05:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javeme javeme javeme approved these changes

@imbajin imbajin imbajin approved these changes

+1 more reviewer

@wangyao2016 wangyao2016 wangyao2016 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corgiboygsj @javeme @wangyao2016 @imbajin