Home Original page

Support deploy command for Remote Execution Deployments by feluelle · Pull Request #1875 · astronomer/astro-cli

Conversation

@feluelle

Description

Describe the purpose of this pull request.

This is to support the Remote Execution configuration for Astro Executor Deploys in the CLI.

🎟 Issue(s)

closes: https://github.com/astronomer/astro/issues/29376

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

jaketf

jaketf previously approved these changes Jun 24, 2025

@jaketf jaketf dismissed their stale review

June 24, 2025 18:52

question about from file suppot

jaketf

DefaultTaskPodMemory: deploymentFromFile.Deployment.Configuration.DefaultTaskPodMemory,
ResourceQuotaCpu: deploymentFromFile.Deployment.Configuration.ResourceQuotaCPU,
ResourceQuotaMemory: deploymentFromFile.Deployment.Configuration.ResourceQuotaMemory,
DefaultTaskPodCpu: &deploymentFromFile.Deployment.Configuration.DefaultTaskPodCPU,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from_file is part of deployment create/update, hence you can find it in #1874

ianbuss

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward to me. Left a small question about the auto-generated API changes.

CreateEnvironmentObjectLinkRequestScopeDEPLOYMENT CreateEnvironmentObjectLinkRequestScope = "DEPLOYMENT"
)

// Defines values for CreateEnvironmentObjectMetricsExportOverridesRequestAuthType.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates in this file seem all unrelated to remote execution and its enablement?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess came along for the ride for free when we updated platform-core?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. I have generated it from the release branch that targeted the v1beta1 platform support.

@feluelle feluelle deleted the feature/remote-exec-deploy branch

June 25, 2025 12:17