feat(wit-parser): allow the non-first segments of the kebab name to start with a number. by chenyan2002 · Pull Request #2355 · bytecodealliance/wasm-tools
Navigation Menu
{{ message }}
bytecodealliance / wasm-tools Public
- Notifications You must be signed in to change notification settings
- Fork 321
Merged
alexcrichton merged 5 commits intobytecodealliance:mainfrom
Oct 20, 2025Merged
Conversation
Copy link
Contributor
chenyan2002
commented
Oct 15, 2025
chenyan2002
commented
Partially address WebAssembly/component-model#345.
Allow the non-first segments of the kebab name to start with a number.
chenyan2002
requested a review
from a team
as a code owner
chenyan2002
requested review from
alexcrichton
and removed request for
a team
chenyan2002
mentioned this pull request
Copy link
Member
alexcrichton
commented
Oct 16, 2025
alexcrichton commented
Oct 16, 2025Thanks! In working on WebAssembly/component-model#345 one thing I want to consider though is the roadmap for how it's going to be implemented. For example I think it would best to avoid situations where half the system works and half the system doesn't due to the order in which things were done. Do you have an idea of how much of he rest of wasm-tools/wasmtime/etc need to be updated for this change? I would naively expect that wasmparser validation might need changing as well but not much else other than that. I wanted to see if you had plans already made though perhaps.
chenyan2002 added 3 commits
October 17, 2025 16:35Copy link
Contributor Author
chenyan2002
commented
Oct 18, 2025
chenyan2002 commented
Oct 18, 2025I think that's all we needed. I tried locally with my wit file. Both wasm-tools and wac (after a bump) are working as expected.
alexcrichton approved these changes Oct 20, 2025
tests/cli/component-model/naming.wast
Show resolved
Hide resolved
tests/cli/component-model/naming.wast Show resolved Hide resolved
alexcrichton
added this pull request to the merge queue
chenyan2002
mentioned this pull request
This was referenced
Nov 14, 2025
alexcrichton
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment