feat(wit-parser): allow the non-first segments of the kebab name to start with a number. by chenyan2002 · Pull Request #2355 · bytecodealliance/wasm-tools

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@chenyan2002

Copy link

Contributor

Partially address WebAssembly/component-model#345.

Allow the non-first segments of the kebab name to start with a number.

@alexcrichton

Copy link

Member

Thanks! In working on WebAssembly/component-model#345 one thing I want to consider though is the roadmap for how it's going to be implemented. For example I think it would best to avoid situations where half the system works and half the system doesn't due to the order in which things were done. Do you have an idea of how much of he rest of wasm-tools/wasmtime/etc need to be updated for this change? I would naively expect that wasmparser validation might need changing as well but not much else other than that. I wanted to see if you had plans already made though perhaps.

@chenyan2002

Copy link

Contributor Author

I think that's all we needed. I tried locally with my wit file. Both wasm-tools and wac (after a bump) are working as expected.

@alexcrichton alexcrichton added this pull request to the merge queue

Oct 20, 2025

Merged via the queue into bytecodealliance:main with commit b0d70e0

Oct 20, 2025

34 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chenyan2002 @alexcrichton