disallow kebab fragment beginning with digit by dicej · Pull Request #2411 · bytecodealliance/wasm-tools
Navigation Menu
{{ message }}
bytecodealliance / wasm-tools Public
- Notifications You must be signed in to change notification settings
- Fork 321
Closed
dicej wants to merge 1 commit intobytecodealliance:mainfrom
Closed
disallow kebab fragment beginning with digit#2411
dicej wants to merge 1 commit intobytecodealliance:mainfrom
disallow kebab fragment beginning with digit#2411
dicej wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
Copy link
Collaborator
dicej
commented
Jan 5, 2026
dicej
commented
Per the word and acronym grammar rules in
https://github.com/WebAssembly/component-model/blob/main/design/mvp/Explainer.md#import-and-export-definitions, a kebab name must not contain a fragment beginning with a digit. This fixes this
test in the spec repo.
Per the `word` and `acronym` grammar rules in https://github.com/WebAssembly/component-model/blob/main/design/mvp/Explainer.md#import-and-export-definitions, a kebab name must not contain a fragment beginning with a digit. This fixes [this test](https://github.com/WebAssembly/component-model/blob/b7fc86e31d71796f107aef276f0944ec6df70dba/test/wasm-tools/naming.wast#L25C1-L30C2) in the spec repo.
dicej
requested a review
from a team
as a code owner
dicej
requested review from
alexcrichton
and removed request for
a team
Copy link
Member
alexcrichton
commented
Jan 5, 2026
alexcrichton commented
Jan 5, 2026This was changed here in this repo in #2355 and provisionally in the component model in WebAssembly/component-model#345, so I think that this might be a case of an upstream test that needs changing
Copy link
Collaborator Author
dicej
commented
Jan 5, 2026
dicej commented
Jan 5, 2026Thanks for pointing that out, @alexcrichton . @lukewagner is going to update the spec when he gets a chance.
dicej
closed this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants