Avoid #includes with a surrounding namespace by dirkmueller · Pull Request #7560 · esp8266/Arduino
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 13.2k
Merged
d-a-v merged 2 commits intoesp8266:masterfrom
Sep 17, 2020Merged
Avoid #includes with a surrounding namespace#7560
d-a-v merged 2 commits intoesp8266:masterfrom
Avoid #includes with a surrounding namespace#7560
d-a-v merged 2 commits intoesp8266:masterfrom
Conversation
Copy link
Contributor
dirkmueller
commented
Aug 29, 2020
dirkmueller
commented
This is a followup of the discussion in
#6946 (comment)
to untangle the namespace/double inclusions in this library.
dirkmueller
marked this pull request as draft
dirkmueller
force-pushed
the
webserver_namespace
branch
from
1fd7d8f to
ffa074e
Compare
dirkmueller
marked this pull request as ready for review
devyte requested changes Aug 31, 2020
libraries/ESP8266WebServer/src/detail/RequestHandlersImpl.h
Outdated
Show resolved
Hide resolved
libraries/ESP8266WebServer/src/detail/RequestHandlersImpl.h Outdated Show resolved Hide resolved
This is a followup of the discussion in esp8266#6946 (comment) to untangle the namespace/double inclusions in this library.
dirkmueller
force-pushed
the
webserver_namespace
branch
from
0b45cee to
2e51afe
Compare
dirkmueller
requested a review
from devyte
d-a-v
mentioned this pull request
6 tasks
d-a-v approved these changes Sep 17, 2020
devyte approved these changes Sep 17, 2020
devyte
added
the
type: code cleanup
label
devyte
added this to the
3.0.0 milestone
d-a-v
merged commit
32470fb
into
esp8266:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment