Support non-ascii (unicode) enum and type names. by josstn · Pull Request #2038 · ferdikoomen/openapi-typescript-codegen

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@josstn

Copy link Copy Markdown

@josstn josstn commented

Feb 14, 2024

This replaces regexp patterns that only worked with ascii characters with more proper matching that supports unicode identifiers in typescript/javascript.

The platform must support "unicode-aware mode" (the u flag) for this to work. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/unicode

nicolas-chaulet and others added 30 commits

January 10, 2024 11:28
Optional response type when 204 response exists
…vices-regexp

feat(client): support regexp to select services to export
…regexp

fix(client): support regexp to select models to export
Introduce a couple of broken schema parsing

Lubos and others added 15 commits

February 3, 2024 07:03
…-option

fix(config): support autoformat option flag
fix(parser): parse array items only if parent has no other item type
…-properties

fix(parser): type additional properties with properties
fix(api): allow overriding request body name with x-body-name key
This replaces regexp patterns that only worked with ascii characters with more proper matching that supports unicode identifiers in typescript/javascript.

The platform must support "unicode-aware mode" (the u flag) for this to work. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/unicode
So that it matches the desired test result.

@mrlubos

Copy link Copy Markdown

Collaborator

mrlubos commented

Feb 14, 2024

@josstn this looks great! Want to open a pull request in our fork too? Otherwise I might merge this myself at some point, great work!

@josstn

Copy link Copy Markdown

Author

josstn commented

Feb 14, 2024

@josstn this looks great! Want to open a pull request in our fork too? Otherwise I might merge this myself at some point, great work!

Sure: hey-api/openapi-ts#14

@josstn

Copy link Copy Markdown

Author

josstn commented

Feb 16, 2024

Replaced by #2040

@josstn josstn closed this

Feb 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@josstn @mrlubos @nicolas-chaulet