Support non-ascii (unicode) enum and type names. by josstn · Pull Request #2038 · ferdikoomen/openapi-typescript-codegen
Navigation Menu
{{ message }}
ferdikoomen / openapi-typescript-codegen Public
- Notifications You must be signed in to change notification settings
- Fork 543
Closed
Support non-ascii (unicode) enum and type names.#2038
josstn wants to merge 47 commits intoferdikoomen:masterfrom
Support non-ascii (unicode) enum and type names.#2038
josstn wants to merge 47 commits intoferdikoomen:masterfrom
Conversation
Copy link Copy Markdown
josstn
commented
Feb 14, 2024
josstn
commented
This replaces regexp patterns that only worked with ascii characters with more proper matching that supports unicode identifiers in typescript/javascript.
The platform must support "unicode-aware mode" (the u flag) for this to work. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/unicode
nicolas-chaulet and others added 30 commits
January 10, 2024 11:28Adding const support
Optional response type when 204 response exists
…type test(snapshot): fix snapshot
…vices-regexp feat(client): support regexp to select services to export
…ction Adding a unittest action
test(ci): match steps from CircleCI
…regexp fix(client): support regexp to select models to export
…pt-codegen into union-bugs
Introduce a couple of broken schema parsing
Lubos and others added 15 commits
February 3, 2024 07:03…-option fix(config): support autoformat option flag
fix(parser): parse array items only if parent has no other item type
…-properties fix(parser): type additional properties with properties
fix(api): allow overriding request body name with x-body-name key
This replaces regexp patterns that only worked with ascii characters with more proper matching that supports unicode identifiers in typescript/javascript. The platform must support "unicode-aware mode" (the u flag) for this to work. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/unicode
josstn
mentioned this pull request
So that it matches the desired test result.
Copy link Copy Markdown
Collaborator
mrlubos
commented
Feb 14, 2024
mrlubos commented
Feb 14, 2024Copy link Copy Markdown
Author
josstn
commented
Feb 14, 2024
josstn commented
Feb 14, 2024@josstn this looks great! Want to open a pull request in our fork too? Otherwise I might merge this myself at some point, great work!
Sure: hey-api/openapi-ts#14
josstn
mentioned this pull request
Copy link Copy Markdown
Author
josstn
commented
Feb 16, 2024
josstn commented
Feb 16, 2024Replaced by #2040
josstn
closed this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment