Support non-ascii (unicode) enum and type names. by josstn · Pull Request #14 · hey-api/openapi-ts
Navigation Menu
{{ message }}
hey-api / openapi-ts Public
- Notifications You must be signed in to change notification settings
- Fork 345
Merged
Support non-ascii (unicode) enum and type names.#14
mrlubos merged 3 commits intohey-api:masterfrom
Support non-ascii (unicode) enum and type names.#14
mrlubos merged 3 commits intohey-api:masterfrom
Conversation
Copy link Copy Markdown
Contributor
josstn
commented
Feb 14, 2024
josstn
commented
This replaces regexp patterns that only worked with ascii characters with more proper matching that supports unicode identifiers in typescript/javascript.
The platform must support "unicode-aware mode" (the u flag) for this to work. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/unicode
josstn added 2 commits
February 14, 2024 10:56This replaces regexp patterns that only worked with ascii characters with more proper matching that supports unicode identifiers in typescript/javascript. The platform must support "unicode-aware mode" (the u flag) for this to work. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/unicode
So that it matches the desired test result.
josstn
marked this pull request as ready for review
josstn
mentioned this pull request
mrlubos
merged commit
325f7ba
into
hey-api:master
Copy link Copy Markdown
Member
mrlubos
commented
Feb 15, 2024
mrlubos commented
Feb 15, 2024This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants