Python: Update Azure Cognitive Search Class Change VectorSearchAlgorithmConfi… by kinfey · Pull Request #2435 · microsoft/semantic-kernel

@kinfey

…guration to HnswVectorSearchAlgorithmConfiguration

@shawncal shawncal changed the title Update Azure Cognitive Search Class Change VectorSearchAlgorithmConfi… Python: Update Azure Cognitive Search Class Change VectorSearchAlgorithmConfi…

Aug 13, 2023

@kinfey

@kinfey

@lemillermicrosoft

lemillermicrosoft

@lemillermicrosoft

@kinfey

dmytrostruk

awharrison-28

github-merge-queue bot pushed a commit that referenced this pull request

Aug 22, 2023
…ctorSearchAlgorithmConfi…" (#2531)

Reverts #2435

This PR caused a breaking change to the ACS memory store's
get_nearest_matches method

github-merge-queue bot pushed a commit that referenced this pull request

Aug 23, 2023
### Motivation and Context

This PR builds on #2435
- the previous PR updates azure-search to the latest package , where it
is recommended to use HnswVectorSearchAlgorithmConfiguration. The
previous implementation appears to be in a semi-deprecated state.

This new flow is the publicly recommended use for ACS according to
https://github.com/Azure/cognitive-search-vector-pr/tree/main/demo-python/code.

### Description
- update `azure-search-documents` dependency from `11.4.0b6 -> 11.4.0b8`
- index configuration changed from `VectorSearchAlgorithmConfiguration
-> HnswVectorSearchAlgorithmConfiguration`
- update `search_client.search()` call in `get_nearest_matches()` to be
consistent with the new index api

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: Kinfey <kinfeylo@microsoft.com>
Co-authored-by: Lee Miller <lemiller@microsoft.com>
Co-authored-by: Kinfey <93169410+kinfey@users.noreply.github.com>

SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this pull request

Nov 1, 2023
…thmConfi… (microsoft#2435)

…guration to HnswVectorSearchAlgorithmConfiguration

### Motivation and Context

Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:

  1. Why is this change required?
  
Azure Cognitive Search SDK Change VectorSearchAlgorithmConfiguration to
HwsnVectorSearchAlgorithmConfiguration
  
  2. What problem does it solve?
  
ImportError: cannot import name 'VectorSearchAlgorithmConfiguration'
from 'azure.search.documents.indexes.models'
  
  3. What scenario does it contribute to?

Python SDK Vector DB Change

  5. If it fixes an open issue, please link to the issue here.
  

https://github.com/Azure/cognitive-search-vector-pr/blob/main/demo-python/code/azure-search-vector-python-sample.ipynb

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Lee Miller <lemiller@microsoft.com>

SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this pull request

Nov 1, 2023
…ctorSearchAlgorithmConfi…" (microsoft#2531)

Reverts microsoft#2435

This PR caused a breaking change to the ACS memory store's
get_nearest_matches method

SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this pull request

Nov 1, 2023
### Motivation and Context

This PR builds on microsoft#2435
- the previous PR updates azure-search to the latest package , where it
is recommended to use HnswVectorSearchAlgorithmConfiguration. The
previous implementation appears to be in a semi-deprecated state.

This new flow is the publicly recommended use for ACS according to
https://github.com/Azure/cognitive-search-vector-pr/tree/main/demo-python/code.

### Description
- update `azure-search-documents` dependency from `11.4.0b6 -> 11.4.0b8`
- index configuration changed from `VectorSearchAlgorithmConfiguration
-> HnswVectorSearchAlgorithmConfiguration`
- update `search_client.search()` call in `get_nearest_matches()` to be
consistent with the new index api

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: Kinfey <kinfeylo@microsoft.com>
Co-authored-by: Lee Miller <lemiller@microsoft.com>
Co-authored-by: Kinfey <93169410+kinfey@users.noreply.github.com>