Home Original page

Python: Revert "Python: Update Azure Cognitive Search Class Change VectorSearchAlgorithmConfi…" by awharrison-28 · Pull Request #2531 · microsoft/semantic-kernel

@awharrison-28

Reverts #2435

This PR caused a breaking change to the ACS memory store's get_nearest_matches method

@awharrison-28

@github-actions github-actions bot changed the title Revert "Python: Update Azure Cognitive Search Class Change VectorSearchAlgorithmConfi…" Python: Revert "Python: Update Azure Cognitive Search Class Change VectorSearchAlgorithmConfi…"

Aug 22, 2023

lemillermicrosoft

dluc

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's hold on for a sec before merging

dluc

dluc approved these changes Aug 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int. tests verified are passing

@dluc dluc deleted the revert-2435-main branch

August 22, 2023 19:53

SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this pull request

Nov 1, 2023 
…ctorSearchAlgorithmConfi…" (microsoft#2531)

Reverts microsoft#2435

This PR caused a breaking change to the ACS memory store's
get_nearest_matches method