Python: ACS should use Hnsw for vector indexing by awharrison-28 · Pull Request #2534 · microsoft/semantic-kernel
and others added 26 commits
August 13, 2023 18:29SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this pull request
Nov 1, 2023### Motivation and Context This PR builds on microsoft#2435 - the previous PR updates azure-search to the latest package , where it is recommended to use HnswVectorSearchAlgorithmConfiguration. The previous implementation appears to be in a semi-deprecated state. This new flow is the publicly recommended use for ACS according to https://github.com/Azure/cognitive-search-vector-pr/tree/main/demo-python/code. ### Description - update `azure-search-documents` dependency from `11.4.0b6 -> 11.4.0b8` - index configuration changed from `VectorSearchAlgorithmConfiguration -> HnswVectorSearchAlgorithmConfiguration` - update `search_client.search()` call in `get_nearest_matches()` to be consistent with the new index api ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Kinfey <kinfeylo@microsoft.com> Co-authored-by: Lee Miller <lemiller@microsoft.com> Co-authored-by: Kinfey <93169410+kinfey@users.noreply.github.com>
crickman
deleted the
feature-python-acs-hnsw
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters