Home Original page

PipeWrap::Connect() should handle errors from uv_pipe_connect2()

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Closed

#50657

@bnoordhuis

Description

553169f switched from uv_pipe_connect() to uv_pipe_connect2(). The former doesn't return errors (it can't because void) but the latter can and does.

The comment here is no longer applicable:

args.GetReturnValue().Set(0); // uv_pipe_connect() doesn't return errors.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions