src: handle errors from uv_pipe_connect2() by deokjinkim · Pull Request #50657

src: handle errors from uv_pipe_connect2() by deokjinkim · Pull Request #50657 · nodejs/node

added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

net

Issues and PRs related to the net subsystem.

labels

Nov 10, 2023

theanarkh added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Nov 12, 2023

This was referenced

Nov 13, 2023

targos pushed a commit that referenced this pull request

Nov 23, 2023

We need to handle errors from uv_pipe_connect2()
because return type is `int`.

Fixes: #50652
Refs: #49667
Refs: libuv/libuv#4030
PR-URL: #50657
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>

UlisesGascon pushed a commit that referenced this pull request

Dec 11, 2023

We need to handle errors from uv_pipe_connect2()
because return type is `int`.

Fixes: #50652
Refs: #49667
Refs: libuv/libuv#4030
PR-URL: #50657
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>