timers: fix unref() memory leak by Fishrock123 · Pull Request #1152 · nodejs/node
added
the
timers
label
Mar 14, 2015
rvagg
mentioned this pull request
Fishrock123 referenced this pull request
Mar 25, 2015The common case is where setInterval() is called with two arguments, the callback and the timeout. Specifying optional arguments in the parameter list forces common case calls to go through an arguments adaptor stack frame. PR-URL: #1221 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
This was referenced
Mar 26, 2015thlorenz referenced this pull request in nodejs/node-v0.x-archive
Mar 30, 2015Unlike the 'exit' event, this event allows the user to schedule more work and thereby postpone the exit. That also means that the 'beforeExit' event may be emitted many times, see the attached test case for an example. Refs #6305.
This change fixes a regression introduced by commit 0d05123, which contained a typo that would cause every unrefd interval to fire only once. Fixes: nodejs/node-v0.x-archive#8900 Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Issues and PRs related to the memory management or memory footprint.
label
Aug 17, 2015This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters