Home Original page

test: regression for `fs` module monkey-patching by thefourtheye · Pull Request #2026 · nodejs/node

@mscdex added fs

Issues and PRs related to the fs subsystem / file system.

test

Issues and PRs related to the tests.

labels

Jun 21, 2015

@thefourtheye 

Testing to make sure that the native `fs` module is monkey-patchable,
as few major libraries like `graceful-fs` rely on this behaviour.

brendanashworth added a commit to brendanashworth/node-graceful-fs that referenced this pull request

Jun 21, 2015 
Fix the horrible atrocity introduced in
08471b2. Previously it would evaluate
the code directly through process.binding(), and it now creates a new
Object with the prototype being the real fs module, exported by core.

Ref: nodejs/node#2026

heavyk added a commit to heavyk/node-graceful-fs that referenced this pull request

Jun 25, 2015

@heavyk

jbenet added a commit to jbenet/gulp-sourcemaps that referenced this pull request

Aug 14, 2015

This was referenced

Feb 5, 2016

ChALkeR added a commit to ChALkeR/io.js that referenced this pull request

Feb 11, 2016 
This is needed to give users a grace period before actually breaking
modules that re-evaluate fs sources from context where internal modules
are not allowed, e.g. older version of graceful-fs module.

To be reverted in Node.js 7.0.

Fixes nodejs#5097, see also nodejs#1898, nodejs#2026, and nodejs#4525.

jasnell pushed a commit that referenced this pull request

Feb 13, 2016 
This is needed to give users a grace period before actually breaking
modules that re-evaluate fs sources from context where internal modules
are not allowed, e.g. older version of graceful-fs module.

To be reverted in Node.js 7.0

Fixes: #5097, see also #1898, #2026, and #4525.
PR-URL: #5102
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

stefanmb pushed a commit to stefanmb/node that referenced this pull request

Feb 23, 2016 
This is needed to give users a grace period before actually breaking
modules that re-evaluate fs sources from context where internal modules
are not allowed, e.g. older version of graceful-fs module.

To be reverted in Node.js 7.0

Fixes: nodejs#5097, see also nodejs#1898, nodejs#2026, and nodejs#4525.
PR-URL: nodejs#5102
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>