Home Original page

fs: add a temporary fix for re-evaluation support by ChALkeR · Pull Request #5102 · nodejs/node

This was referenced

Feb 5, 2016

@Fishrock123 Fishrock123 added the fs

Issues and PRs related to the fs subsystem / file system.

label

Feb 5, 2016

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request

Feb 9, 2016 
This reverts commit 1124de2
which landed in nodejs#4525

This commit has broken both npm + node-gyp

How did it break npm?

Deprecating fs.read's string interface includes `internal/util`
Currently npm's dep tree includes an old version of graceful-fs
that is monkey patching fs. As such everything explodes when
trying to require `internal/util`

nodejs#5102 is waiting for review
but has not landed. We should revert ASAP to fix master while
we decide what to do.

@MylesBorins MylesBorins added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Feb 9, 2016

stefanmb pushed a commit to stefanmb/node that referenced this pull request

Feb 23, 2016 
This is needed to give users a grace period before actually breaking
modules that re-evaluate fs sources from context where internal modules
are not allowed, e.g. older version of graceful-fs module.

To be reverted in Node.js 7.0

Fixes: nodejs#5097, see also nodejs#1898, nodejs#2026, and nodejs#4525.
PR-URL: nodejs#5102
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

This was referenced

May 5, 2016

This was referenced

May 13, 2016