test: fix test failure on aix by BridgeAR · Pull Request #20940 · nodejs/node

Expand Up @@ -15,7 +15,7 @@ const { spawnSync } = require('child_process');
const ret = spawnSync( process.execPath, ['--stack_size=50', __filename, 'async'] ['--stack_size=75', __filename, 'async'] ); assert.strictEqual(ret.status, 0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fwiw, I think this would have been more easily debuggable if this assertion had come last and the assertion on L22 would print out stderr in its failure message – maybe we can fix up the test for that as well?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, actually, I had a branch to fix this and then didn't open a PR, but maybe it can be tacked onto this. IIRC, the change was this:

assert.strictEqual(ret.status, 0,
                   `EXIT CODE: ${ret.status}, STDERR: ${ret.stderr}`);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #20948 so that this one doesn't get delayed with any bike-shedding or CI re-running.

const stderr = ret.stderr.toString('utf8', 0, 2048); Expand Down