Home Original page

test: improve error message in async-wrap test by Trott · Pull Request #20948 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

May 24, 2018

richardlau

@Trott

@Trott Trott mentioned this pull request

May 24, 2018

4 tasks

@Trott Trott added the fast-track

PRs that do not need to wait for 72 hours to land.

label

May 24, 2018

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 24, 2018

BridgeAR

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

May 25, 2018 
Improve AssertionError message in
test/parallel/test-async-wrap-pop-id-during-load.js to include the
contents of stderr when the spawned process fails.

Refs: https://github.com/nodejs/node/pull/20940/files#r190707951

PR-URL: nodejs#20948
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

May 29, 2018 
Improve AssertionError message in
test/parallel/test-async-wrap-pop-id-during-load.js to include the
contents of stderr when the spawned process fails.

Refs: https://github.com/nodejs/node/pull/20940/files#r190707951

PR-URL: #20948
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

Open

@Trott Trott deleted the improve-err-msg branch

January 13, 2022 22:49