Home Original page

process,tty: allow reading/writing from duplex sockets by addaleax · Pull Request #23053 · nodejs/node

added 4 commits

September 24, 2018 11:15
Since faking TTY input is not otherwise fake-able, we need
support in the test runner for it.
Allow reading from stdio streams that are conventionally
associated with process output, since this is only convention.

This involves disabling the oddness around closing stdio
streams. Its purpose is to prevent the file descriptors
0 through 2 from being closed, since doing so can lead
to information leaks when new file descriptors are being
opened; instead, not doing anything seems like a more
reasonable choice.

Fixes: nodejs#21203
Make sure that `process.stdin.write()`, and in particular
ending the stream, works.

@addaleax addaleax added process

Issues and PRs related to the process subsystem.

tty

Issues and PRs related to the tty subsystem.

labels

Sep 24, 2018

vsemozhetbyt

@addaleax

@addaleax

vsemozhetbyt

@addaleax

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Oct 3, 2018

addaleax added a commit that referenced this pull request

Oct 4, 2018

addaleax added a commit that referenced this pull request

Oct 4, 2018 
Since faking TTY input is not otherwise fake-able, we need
support in the test runner for it.

PR-URL: #23053
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit that referenced this pull request

Oct 4, 2018 
Allow reading from stdio streams that are conventionally
associated with process output, since this is only convention.

This involves disabling the oddness around closing stdio
streams. Its purpose is to prevent the file descriptors
0 through 2 from being closed, since doing so can lead
to information leaks when new file descriptors are being
opened; instead, not doing anything seems like a more
reasonable choice.

Fixes: #21203

PR-URL: #23053
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit that referenced this pull request

Oct 4, 2018 
Make sure that `process.stdin.write()`, and in particular
ending the stream, works.

PR-URL: #23053
Reviewed-By: James M Snell <jasnell@gmail.com>

@refack refack added test

Issues and PRs related to the tests.

python

PRs and issues that require attention from people who are familiar with Python.

labels

Oct 4, 2018

This was referenced

Oct 11, 2018

jasnell pushed a commit that referenced this pull request

Oct 17, 2018

jasnell pushed a commit that referenced this pull request

Oct 17, 2018 
Since faking TTY input is not otherwise fake-able, we need
support in the test runner for it.

PR-URL: #23053
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell pushed a commit that referenced this pull request

Oct 17, 2018 
Allow reading from stdio streams that are conventionally
associated with process output, since this is only convention.

This involves disabling the oddness around closing stdio
streams. Its purpose is to prevent the file descriptors
0 through 2 from being closed, since doing so can lead
to information leaks when new file descriptors are being
opened; instead, not doing anything seems like a more
reasonable choice.

Fixes: #21203

PR-URL: #23053
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell pushed a commit that referenced this pull request

Oct 17, 2018 
Make sure that `process.stdin.write()`, and in particular
ending the stream, works.

PR-URL: #23053
Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced

Oct 23, 2018

addaleax added a commit to addaleax/node that referenced this pull request

Jan 22, 2019

addaleax added a commit that referenced this pull request

Jan 27, 2019 
This has been unused since cbc3ef6.

Refs: #23053

PR-URL: #25641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

addaleax added a commit that referenced this pull request

Jan 28, 2019 
This has been unused since cbc3ef6.

Refs: #23053

PR-URL: #25641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

BethGriggs pushed a commit that referenced this pull request

Mar 19, 2019 
Since faking TTY input is not otherwise fake-able, we need
support in the test runner for it.

Backport-PR-URL: #25351
PR-URL: #23053
Reviewed-By: James M Snell <jasnell@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Mar 19, 2019 
Allow reading from stdio streams that are conventionally
associated with process output, since this is only convention.

This involves disabling the oddness around closing stdio
streams. Its purpose is to prevent the file descriptors
0 through 2 from being closed, since doing so can lead
to information leaks when new file descriptors are being
opened; instead, not doing anything seems like a more
reasonable choice.

Fixes: #21203

Backport-PR-URL: #25351
PR-URL: #23053
Reviewed-By: James M Snell <jasnell@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Mar 19, 2019 
Make sure that `process.stdin.write()`, and in particular
ending the stream, works.

Backport-PR-URL: #25351
PR-URL: #23053
Reviewed-By: James M Snell <jasnell@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Apr 29, 2019 
This has been unused since cbc3ef6.

Refs: #23053

PR-URL: #25641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

BethGriggs pushed a commit that referenced this pull request

May 10, 2019 
This has been unused since cbc3ef6.

Refs: #23053

PR-URL: #25641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins pushed a commit that referenced this pull request

May 16, 2019 
This has been unused since cbc3ef6.

Refs: #23053

PR-URL: #25641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@ronag ronag mentioned this pull request

Mar 20, 2020

4 tasks

@ronag ronag mentioned this pull request

May 4, 2020

abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request

May 5, 2024 
Since faking TTY input is not otherwise fake-able, we need
support in the test runner for it.

PR-URL: nodejs/node#23053
Reviewed-By: James M Snell <jasnell@gmail.com>

abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request

May 5, 2024 
Allow reading from stdio streams that are conventionally
associated with process output, since this is only convention.

This involves disabling the oddness around closing stdio
streams. Its purpose is to prevent the file descriptors
0 through 2 from being closed, since doing so can lead
to information leaks when new file descriptors are being
opened; instead, not doing anything seems like a more
reasonable choice.

Fixes: nodejs/node#21203

PR-URL: nodejs/node#23053
Reviewed-By: James M Snell <jasnell@gmail.com>

abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request

May 5, 2024 
Make sure that `process.stdin.write()`, and in particular
ending the stream, works.

PR-URL: nodejs/node#23053
Reviewed-By: James M Snell <jasnell@gmail.com>