Home Original page

[v8.x] Backport tty fixes by mcollina · Pull Request #25351 · nodejs/node

and others added 4 commits

January 5, 2019 12:44
Since faking TTY input is not otherwise fake-able, we need
support in the test runner for it.

PR-URL: nodejs#23053
Reviewed-By: James M Snell <jasnell@gmail.com>
Allow reading from stdio streams that are conventionally
associated with process output, since this is only convention.

This involves disabling the oddness around closing stdio
streams. Its purpose is to prevent the file descriptors
0 through 2 from being closed, since doing so can lead
to information leaks when new file descriptors are being
opened; instead, not doing anything seems like a more
reasonable choice.

Fixes: nodejs#21203

PR-URL: nodejs#23053
Reviewed-By: James M Snell <jasnell@gmail.com>
Make sure that `process.stdin.write()`, and in particular
ending the stream, works.

PR-URL: nodejs#23053
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#23051
Fixes: nodejs#22814
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@mcollina mcollina added the semver-minor

PRs that contain new features and should be released in the next minor version.

label

Jan 5, 2019

@nodejs-github-bot nodejs-github-bot added errors

Issues and PRs related to JavaScript errors originated in Node.js core.

process

Issues and PRs related to the process subsystem.

test

Issues and PRs related to the tests.

tools

Issues and PRs related to the tools directory.

v8.x labels

Jan 5, 2019

BridgeAR

BethGriggs pushed a commit that referenced this pull request

Mar 19, 2019 
Since faking TTY input is not otherwise fake-able, we need
support in the test runner for it.

Backport-PR-URL: #25351
PR-URL: #23053
Reviewed-By: James M Snell <jasnell@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Mar 19, 2019 
Allow reading from stdio streams that are conventionally
associated with process output, since this is only convention.

This involves disabling the oddness around closing stdio
streams. Its purpose is to prevent the file descriptors
0 through 2 from being closed, since doing so can lead
to information leaks when new file descriptors are being
opened; instead, not doing anything seems like a more
reasonable choice.

Fixes: #21203

Backport-PR-URL: #25351
PR-URL: #23053
Reviewed-By: James M Snell <jasnell@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Mar 19, 2019 
Make sure that `process.stdin.write()`, and in particular
ending the stream, works.

Backport-PR-URL: #25351
PR-URL: #23053
Reviewed-By: James M Snell <jasnell@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Mar 19, 2019 
Backport-PR-URL: #25351
PR-URL: #23051
Fixes: #22814
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>