Home Original page

fs: do basic arg validation of truncate in js by thefourtheye · Pull Request #2498 · nodejs/node

@thefourtheye added the fs

Issues and PRs related to the fs subsystem / file system.

label

Aug 22, 2015

@jasnell jasnell added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Feb 13, 2016

@thefourtheye 

This patch moves the basic validation of arguments to `truncate` family
of functions to the JavaScript from the C++ layer.

thefourtheye added a commit that referenced this pull request

Jul 21, 2016 
This patch

 1. moves the basic validation of arguments to `truncate` family
    of functions to the JavaScript layer from the C++ layer.

 2. makes sure that the File Descriptors are validated strictly.

PR-URL: #2498
Reviewed-By: Trevor Norris <trev.norris@gmail.com>

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request

Jul 22, 2016 
This reverts commit c86c1ee.

original commit message:

    This patch

     1. moves the basic validation of arguments to `truncate` family
        of functions to the JavaScript layer from the C++ layer.

     2. makes sure that the File Descriptors are validated strictly.

    PR-URL: nodejs#2498
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request

Aug 4, 2016 
This reverts commit c86c1ee.

original commit message:

    This patch

     1. moves the basic validation of arguments to `truncate` family
        of functions to the JavaScript layer from the C++ layer.

     2. makes sure that the File Descriptors are validated strictly.

    PR-URL: nodejs#2498
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>

PR-URL: nodejs#7950
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced

Mar 29, 2024

This was referenced

Mar 30, 2024

This was referenced

Mar 30, 2024