Home Original page

Revert "fs: validate args of truncate functions in js" by MylesBorins · Pull Request #7950 · nodejs/node

@MylesBorins added the fs

Issues and PRs related to the fs subsystem / file system.

label

Aug 2, 2016

@nodejs-github-bot nodejs-github-bot added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Aug 2, 2016

@MylesBorins 

This reverts commit c86c1ee.

original commit message:

    This patch

     1. moves the basic validation of arguments to `truncate` family
        of functions to the JavaScript layer from the C++ layer.

     2. makes sure that the File Descriptors are validated strictly.

    PR-URL: nodejs#2498
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>

PR-URL: nodejs#7950
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>