Home Original page

win, build: add arbitrary MSBuild flag option and binlog option by jkunkee · Pull Request #25994 · nodejs/node

@nodejs-github-bot added build

Issues and PRs related to build files or the CI.

windows

Issues and PRs related to the Windows platform.

labels

Feb 7, 2019

@jkunkee jkunkee changed the title win, build: add 'verbose' mode and improve environment management win, build: add 'verbose' mode and scope environment changes

Feb 7, 2019

refack

refack

@jkunkee jkunkee changed the title win, build: add 'verbose' mode and scope environment changes win, build: add arbitrary MSBuild flag option and binlog option

Feb 10, 2019

joaocgreis

@jkunkee 

This change adds a 'msbuild_arg' option to vcbuild.bat that can be used
to pass arbitrary flags to MSBuild.

It also adds a 'binlog' flag as a shortcut 'msbuild_arg' option to
enable binary logging to `%config%\node.binlog`. This is especially
convenient when debugging changes to the build system.

In the process of developing this change, the idea of adding 'setlocal'
to the beginning of the script was rejected since other scripts in this
repo rely on the exported environment variables. This change adds a
note describing this.

joaocgreis pushed a commit that referenced this pull request

Mar 4, 2019 
This change adds a 'msbuild_arg' option to vcbuild.bat that can be used
to pass arbitrary flags to MSBuild.

It also adds a 'binlog' flag as a shortcut 'msbuild_arg' option to
enable binary logging to `%config%\node.binlog`. This is especially
convenient when debugging changes to the build system.

In the process of developing this change, the idea of adding 'setlocal'
to the beginning of the script was rejected since other scripts in this
repo rely on the exported environment variables. This change adds a
note describing this.

PR-URL: #25994
Reviewed-By: João Reis <reis@janeasystems.com>

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Mar 6, 2019 
PR-URL: nodejs#26431
Refs: nodejs#25994
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@jkunkee jkunkee deleted the win-build-script-tweaks branch

March 8, 2019 02:40

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Mar 12, 2019 
This change adds a 'msbuild_arg' option to vcbuild.bat that can be used
to pass arbitrary flags to MSBuild.

It also adds a 'binlog' flag as a shortcut 'msbuild_arg' option to
enable binary logging to `%config%\node.binlog`. This is especially
convenient when debugging changes to the build system.

In the process of developing this change, the idea of adding 'setlocal'
to the beginning of the script was rejected since other scripts in this
repo rely on the exported environment variables. This change adds a
note describing this.

PR-URL: nodejs#25994
Reviewed-By: João Reis <reis@janeasystems.com>

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Mar 12, 2019 
PR-URL: nodejs#26431
Refs: nodejs#25994
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BridgeAR pushed a commit that referenced this pull request

Mar 14, 2019 
PR-URL: #26431
Refs: #25994
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BethGriggs pushed a commit that referenced this pull request

Apr 16, 2019 
This change adds a 'msbuild_arg' option to vcbuild.bat that can be used
to pass arbitrary flags to MSBuild.

It also adds a 'binlog' flag as a shortcut 'msbuild_arg' option to
enable binary logging to `%config%\node.binlog`. This is especially
convenient when debugging changes to the build system.

In the process of developing this change, the idea of adding 'setlocal'
to the beginning of the script was rejected since other scripts in this
repo rely on the exported environment variables. This change adds a
note describing this.

PR-URL: #25994
Reviewed-By: João Reis <reis@janeasystems.com>

This was referenced

May 29, 2019