Home Original page

build,win: simplify new `msbuild_arg` option by refack · Pull Request #26431 · nodejs/node

@nodejs-github-bot added build

Issues and PRs related to build files or the CI.

windows

Issues and PRs related to the Windows platform.

labels

Mar 4, 2019

@refack

joaocgreis

richardlau

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 5, 2019

BridgeAR

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Mar 6, 2019 
PR-URL: nodejs#26431
Refs: nodejs#25994
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@refack refack deleted the tweak-vcbuld-change branch

March 7, 2019 14:37

@refack refack added landed and removed author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

labels

Mar 7, 2019

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Mar 12, 2019 
PR-URL: nodejs#26431
Refs: nodejs#25994
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BridgeAR pushed a commit that referenced this pull request

Mar 14, 2019 
PR-URL: #26431
Refs: #25994
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>