Home Original page

stream: invoke buffered write callbacks on error by ronag · Pull Request #30596 · nodejs/node

@nodejs-github-bot added the stream

Issues and PRs related to the stream subsystem.

label

Nov 22, 2019

ronag

mcollina

addaleax

lpinca

@BridgeAR BridgeAR added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

and removed author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

labels

Dec 24, 2019

Trott pushed a commit that referenced this pull request

Dec 31, 2019 
Buffered write callbacks were only invoked upon
error if `autoDestroy` was invoked.

PR-URL: #30596
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@ronag ronag mentioned this pull request

Jan 3, 2020

4 tasks

ronag added a commit to nxtedition/node that referenced this pull request

Jan 3, 2020 
Buffered write callbacks were only invoked upon
error if `autoDestroy` was invoked.

Backport-PR-URL: nodejs#31179
PR-URL: nodejs#30596
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

codebytere pushed a commit that referenced this pull request

Feb 29, 2020 
Refs: #30596

Buffered write callbacks were only invoked upon
error if `autoDestroy` was invoked.

Backport-PR-URL: #31179
PR-URL: #30596
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

lpinca added a commit to websockets/ws that referenced this pull request

Mar 3, 2020 
If the socket is closed while data is being compressed, invoke the
current send callback and the buffered send callbacks with an error
before emitting the `'close'` event.

Refs: nodejs/node#30596

lpinca added a commit to websockets/ws that referenced this pull request

Mar 7, 2020 
If the socket is closed while data is being compressed, invoke the
current send callback and the buffered send callbacks with an error
before emitting the `'close'` event.

Refs: nodejs/node#30596