Home Original page

[v13.x backport] stream: invoke buffered write callbacks on error by ronag · Pull Request #31179 · nodejs/node

@nodejs-github-bot added stream

Issues and PRs related to the stream subsystem.

v13.x labels

Jan 3, 2020

@ronag 

Buffered write callbacks were only invoked upon
error if `autoDestroy` was invoked.

Backport-PR-URL: nodejs#31179
PR-URL: nodejs#30596
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@ronag ronag mentioned this pull request

Jan 3, 2020

4 tasks

@ronag

BridgeAR

mcollina

@ronag ronag mentioned this pull request

Jan 6, 2020

@ronag ronag mentioned this pull request

Jan 6, 2020

@lpinca lpinca removed the blocked

PRs that are blocked by other issues or PRs.

label

Feb 27, 2020

@ronag ronag added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 27, 2020

codebytere

codebytere pushed a commit that referenced this pull request

Feb 29, 2020 
Refs: #30596

Buffered write callbacks were only invoked upon
error if `autoDestroy` was invoked.

Backport-PR-URL: #31179
PR-URL: #30596
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>