stream: finished should invoke callback for closed streams by ronag · Pull Request #31509

stream: finished should invoke callback for closed streams by ronag · Pull Request #31509 · nodejs/node

added the lib / src

Issues and PRs related to general changes in the lib or src directory.

label

Jan 25, 2020

ronag added semver-major

PRs that contain breaking changes and should be released in the next major version.

stream

Issues and PRs related to the stream subsystem.

labels

Jan 25, 2020

ronag mentioned this pull request

Jan 26, 2020

3 tasks

ronag added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jan 26, 2020

Trott removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jan 27, 2020

ronag mentioned this pull request

Jan 27, 2020

4 tasks

Previously finished(stream, cb) would not invoke the callback for streams
that have already finished, ended or errored before being
passed to finished(stream, cb).

ronag added a commit that referenced this pull request

Feb 8, 2020

Previously finished(stream, cb) would not invoke the callback
for streams that have already finished, ended or errored
before being passed to finished(stream, cb).

PR-URL: #31509
Refs: #31508
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

ronag mentioned this pull request

Feb 20, 2020

4 tasks

ronag added a commit to nxtedition/node that referenced this pull request

Feb 20, 2020

ronag added a commit that referenced this pull request

Feb 22, 2020

#31509 introduced a slight typo.
Fortunately this typo does not have big impact due to
`isWritableFinished()`.

Fixes: #31509 (comment)

PR-URL: #31881
Fixes: #31509
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

ronag mentioned this pull request

Feb 29, 2020

4 tasks

ronag mentioned this pull request

Apr 14, 2020

ronag mentioned this pull request

Apr 25, 2020

4 tasks