Home Original page

stream: fix finished typo by ronag · Pull Request #31881 · nodejs/node

@ronag

#31509 introduced a slight typo. Fortunately this typo does not have big impact due to isWritableFinished().

Fixes: #31509 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag ronag added the stream

Issues and PRs related to the stream subsystem.

label

Feb 20, 2020

@ronag

@nodejs-github-bot

tniessen

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated whitespace change?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, there was an extra whitespace that shouldn't be there...

mcollina

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

lpinca

@ronag ronag added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 20, 2020

ronag added a commit that referenced this pull request

Feb 22, 2020 
#31509 introduced a slight typo.
Fortunately this typo does not have big impact due to
`isWritableFinished()`.

Fixes: #31509 (comment)

PR-URL: #31881
Fixes: #31509
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@ronag

@MylesBorins

Adding don't land labels as this relies on a semver-major change