Home Original page

stream: fix broken pipeline error propagation by ronag · Pull Request #31835 · nodejs/node

ronag

ronag

@ronag ronag added the stream

Issues and PRs related to the stream subsystem.

label

Feb 17, 2020

mcollina

ronag

@ronag ronag added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 21, 2020

@ronag ronag changed the title stream: fix broken pipeline tests stream: fix broken pipeline error propagation

Feb 21, 2020

@ronag 

If the destination was an async function any
error thrown from that function would be swallowed.

benjamingr

benjamingr

mcollina

@ronag

lundibundi

Co-Authored-By: Denys Otrishko <shishugi@gmail.com>

@ronag

ronag added a commit that referenced this pull request

Feb 24, 2020 
If the destination was an async function any
error thrown from that function would be swallowed.

PR-URL: #31835
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>

ronag added a commit to nxtedition/node that referenced this pull request

Feb 27, 2020 
If the destination was an async function any
error thrown from that function would be swallowed.

Backport-PR-URL: nodejs#31975
PR-URL: nodejs#31835
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>

codebytere pushed a commit that referenced this pull request

Mar 1, 2020 
If the destination was an async function any
error thrown from that function would be swallowed.

Backport-PR-URL: #31975
PR-URL: #31835
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>