Home Original page

[v13.x backport] stream: support passing generator functions into pipeline() by ronag · Pull Request #31975 · nodejs/node

@nodejs-github-bot added doc

Issues and PRs related to the documentations.

tools

Issues and PRs related to the tools directory.

v13.x labels

Feb 26, 2020

@ronag ronag added stream

Issues and PRs related to the stream subsystem.

notable-change

PRs with changes that should be highlighted in changelogs.

and removed tools

Issues and PRs related to the tools directory.

labels

Feb 26, 2020

@ronag ronag added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

and removed notable-change

PRs with changes that should be highlighted in changelogs.

labels

Feb 26, 2020

codebytere

Backport-PR-URL: nodejs#31975
PR-URL: nodejs#31223
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
If the destination was an async function any
error thrown from that function would be swallowed.

Backport-PR-URL: nodejs#31975
PR-URL: nodejs#31835
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
There was an edge case where an incorrect assumption was made
in regardos whether eos/finished means that the stream is
actually destroyed or not.

Backport-PR-URL: nodejs#31975
PR-URL: nodejs#31940
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

codebytere pushed a commit that referenced this pull request

Mar 1, 2020 
Backport-PR-URL: #31975
PR-URL: #31223
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

codebytere pushed a commit that referenced this pull request

Mar 1, 2020 
If the destination was an async function any
error thrown from that function would be swallowed.

Backport-PR-URL: #31975
PR-URL: #31835
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>

codebytere pushed a commit that referenced this pull request

Mar 1, 2020 
There was an edge case where an incorrect assumption was made
in regardos whether eos/finished means that the stream is
actually destroyed or not.

Backport-PR-URL: #31975
PR-URL: #31940
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@ronag ronag mentioned this pull request

Mar 9, 2020

4 tasks