Home Original page

module: move unnecessary work for early return by zertosh · Pull Request #3579 · nodejs/node

@zertosh changed the title module: move unnecessary work for early return lib: move unnecessary work for early return

Oct 29, 2015

@zertosh zertosh changed the title lib: move unnecessary work for early return module: move unnecessary work for early return

Oct 29, 2015

@Trott Trott added the module

Issues and PRs related to the module subsystem.

label

Oct 29, 2015

@zertosh 

`exts` and `trailingSlash` are only used if the path isn't cached.

cjihrig pushed a commit that referenced this pull request

Jan 11, 2016 
The exts and trailingSlash variables are only used if the
path isn't cached. This commit moves them further down in the
code, and changes from var to const.

PR-URL: #3579
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Jan 11, 2016 
The exts and trailingSlash variables are only used if the
path isn't cached. This commit moves them further down in the
code, and changes from var to const.

PR-URL: #3579
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Jan 11, 2016 
Notable Changes:

* Minor performance improvements:
  - lib: Use arrow functions instead of bind where possible (Minwoo Jung) #3622.
    - (Mistakenly missing from v5.4.0)
  - module: move unnecessary work for early return (Andres Suarez) #3579
* Various doc fixes
* Various test improvements

PR-URL: #4626

MylesBorins pushed a commit that referenced this pull request

Jan 12, 2016 
The exts and trailingSlash variables are only used if the
path isn't cached. This commit moves them further down in the
code, and changes from var to const.

PR-URL: #3579
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Jan 12, 2016 
Notable Changes:

* Minor performance improvements:
  - module: move unnecessary work for early return (Andres Suarez) #3579
* Various bug fixes
* Various doc fixes
* Various test improvements

PR-URL: #4626

MylesBorins pushed a commit that referenced this pull request

Jan 13, 2016 
Notable Changes:

* Minor performance improvements:
  - module: move unnecessary work for early return (Andres Suarez) #3579
* Various bug fixes
* Various doc fixes
* Various test improvements

PR-URL: #4626
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins pushed a commit that referenced this pull request

Jan 28, 2016 
The exts and trailingSlash variables are only used if the
path isn't cached. This commit moves them further down in the
code, and changes from var to const.

PR-URL: #3579
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Feb 11, 2016 
The exts and trailingSlash variables are only used if the
path isn't cached. This commit moves them further down in the
code, and changes from var to const.

PR-URL: #3579
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request

Feb 11, 2016 
The exts and trailingSlash variables are only used if the
path isn't cached. This commit moves them further down in the
code, and changes from var to const.

PR-URL: nodejs#3579
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request

Feb 15, 2016 
The exts and trailingSlash variables are only used if the
path isn't cached. This commit moves them further down in the
code, and changes from var to const.

PR-URL: nodejs#3579
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

scovetta pushed a commit to scovetta/node that referenced this pull request

Apr 2, 2016 
The exts and trailingSlash variables are only used if the
path isn't cached. This commit moves them further down in the
code, and changes from var to const.

PR-URL: nodejs#3579
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

scovetta pushed a commit to scovetta/node that referenced this pull request

Apr 2, 2016 
Notable Changes:

* Minor performance improvements:
  - module: move unnecessary work for early return (Andres Suarez) nodejs#3579
* Various bug fixes
* Various doc fixes
* Various test improvements

PR-URL: nodejs#4626
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>