V5.4.1 propose by MylesBorins · Pull Request #4626 · nodejs/node

MylesBorins pushed a commit that referenced this pull request

Jan 11, 2016
Notable Changes:

* Minor performance improvements:
  - lib: Use arrow functions instead of bind where possible (Minwoo Jung) #3622.
    - (Mistakenly missing from v5.4.0)
  - module: move unnecessary work for early return (Andres Suarez) #3579
* Various doc fixes
* Various test improvements

PR-URL: #4626

@mscdex mscdex added the meta

Issues and PRs related to the general management of the project.

label

Jan 11, 2016
General improvements to crypto.markdown including new and
revised examples.

PR-URL: #4435
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
PR-URL: #4549
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: #3254
PR-URL: #4540
Reviewed-By: James M Snell <jasnell@gmail.com>
Adds Myles Borins and his public key to the README

PR-URL: #4578
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Adds Evan Lucas and his public key to the README for releases

PR-URL: #4579
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
It avoids the creation of unnecessary handles. This issue is causing
intermitent failures in `test-cluster-disconnect-race` on `FreeBSD`
and `OS X`.

The problem is that the `worker2.disconnect` is being called on the
master before the `queryServer` is handled, causing the worker to
be deleted, then the Server handle is created afterwards. Later on,
when `removeWorker` is called from the `exit` handler, there are no
workers left, but one handle, thus the `AssertionError`.

Add a new `test/sequential/test-cluster-disconnect-leak` based on
`test-cluster-disconnect-race` that creates lots of workers and fails
consistently without this patch.

PR-URL: #4465
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
fix description about the latest LTS release download page
to make it clear

PR-URL: #4583
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
A few tests in test/gc include the http module twice. Remove duplicate
require().

PR-URL: #4606
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
The exts and trailingSlash variables are only used if the
path isn't cached. This commit moves them further down in the
code, and changes from var to const.

PR-URL: #3579
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Two tests were requiring the common module twice. This removes the
duplicate require statement in the tests.

PR-URL: #4611
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Remove redeclarations of variables in node.js. This includes removing
one apparently unnecessary `NativeModule.require('module')`.

PR-URL: #4605
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
In lib/_http_client.js, the variable `conn` was declared with the `var`
keyword three times in the same scope. This change eliminates the
variable entirely.

PR-URL: #4612
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
In order to make developers aware of node-core built-in
functionality, which might replace module APIs, we should
add an example of readline`s interface usage.
SEO will eventually aid this goal, since it is well searched
on Q&A sites.

PR-URL: #4609
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>>
Do not attempt to read data from the socket whilst on OpenSSL's stack,
weird things may happen, and this is most likely going to result in some
kind of error.

PR-URL: #4624
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This comment was added with an assumption that we could determine the
IP address that localhost should resolve to without performing a
lookup. This was a false assumption and should be removed.

PR-URL: #4648
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
`fork` is imported twice in a row. Remove duplication.

PR-URL: #4634
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

Myles Borins added 2 commits

January 12, 2016 12:48
Notable Changes:

* Minor performance improvements:
  - module: move unnecessary work for early return (Andres Suarez) #3579
* Various bug fixes
* Various doc fixes
* Various test improvements

PR-URL: #4626

MylesBorins pushed a commit that referenced this pull request

Jan 13, 2016
Notable Changes:

* Minor performance improvements:
  - module: move unnecessary work for early return (Andres Suarez) #3579
* Various bug fixes
* Various doc fixes
* Various test improvements

PR-URL: #4626
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

@rvagg rvagg deleted the v5.4.1-propose branch

January 13, 2016 08:58

Starefossen pushed a commit to Starefossen/docker-node that referenced this pull request

Jan 13, 2016

Starefossen pushed a commit to Starefossen/official-images that referenced this pull request

Jan 13, 2016

Starefossen pushed a commit to Starefossen/official-images that referenced this pull request

Jan 13, 2016

scovetta pushed a commit to scovetta/node that referenced this pull request

Apr 2, 2016
Notable Changes:

* Minor performance improvements:
  - module: move unnecessary work for early return (Andres Suarez) nodejs#3579
* Various bug fixes
* Various doc fixes
* Various test improvements

PR-URL: nodejs#4626
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

RichardScothern pushed a commit to RichardScothern/official-images that referenced this pull request

Jun 14, 2016