Home Original page

build: disable flag v8_scriptormodule_legacy_lifetime by legendecas · Pull Request #50616 · nodejs/node

@legendecas 

Usages of `v8::ScriptOrModule` were removed in nodejs#44198
so the flag can be disabled by default.

@nodejs-github-bot added needs-ci

PRs that need a full CI run.

tools

Issues and PRs related to the tools directory.

v8 engine

Issues and PRs related to the V8 dependency.

labels

Nov 7, 2023

richardlau

targos pushed a commit that referenced this pull request

Nov 23, 2023 
Usages of `v8::ScriptOrModule` were removed in #44198
so the flag can be disabled by default.

PR-URL: #50616
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

martenrichter pushed a commit to martenrichter/node that referenced this pull request

Nov 26, 2023 
Usages of `v8::ScriptOrModule` were removed in nodejs#44198
so the flag can be disabled by default.

PR-URL: nodejs#50616
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

lucshi pushed a commit to lucshi/node that referenced this pull request

Nov 27, 2023 
Usages of `v8::ScriptOrModule` were removed in nodejs#44198
so the flag can be disabled by default.

PR-URL: nodejs#50616
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

RafaelGSS pushed a commit that referenced this pull request

Nov 29, 2023 
Usages of `v8::ScriptOrModule` were removed in #44198
so the flag can be disabled by default.

PR-URL: #50616
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

RafaelGSS pushed a commit that referenced this pull request

Nov 30, 2023 
Usages of `v8::ScriptOrModule` were removed in #44198
so the flag can be disabled by default.

PR-URL: #50616
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

UlisesGascon pushed a commit that referenced this pull request

Dec 11, 2023 
Usages of `v8::ScriptOrModule` were removed in #44198
so the flag can be disabled by default.

PR-URL: #50616
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

UlisesGascon pushed a commit that referenced this pull request

Dec 19, 2023 
Usages of `v8::ScriptOrModule` were removed in #44198
so the flag can be disabled by default.

PR-URL: #50616
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>