Home Original page

src: remove usages on ScriptCompiler::CompileFunctionInContext by legendecas · Pull Request #44198 · nodejs/node

@legendecas 

V8 APIs like HostImportModuleDynamicallyCallback and
ScriptCompiler::CompileFunction is moving away from ScriptOrModule.

Replaces ScriptCompiler::CompileFunctionInContext with
ScriptCompiler::CompileFunction to remove the usages on the optional
out param ScriptOrModule.

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

lib / src

Issues and PRs related to general changes in the lib or src directory.

needs-ci

PRs that need a full CI run.

labels

Aug 10, 2022

joyeecheung

legendecas added a commit that referenced this pull request

Aug 15, 2022 
V8 APIs like HostImportModuleDynamicallyCallback and
ScriptCompiler::CompileFunction is moving away from ScriptOrModule.

Replaces ScriptCompiler::CompileFunctionInContext with
ScriptCompiler::CompileFunction to remove the usages on the optional
out param ScriptOrModule.

PR-URL: #44198
Fixes: nodejs/node-v8#214
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@legendecas legendecas deleted the deprecate-compile-function-in-context branch

August 15, 2022 17:39

danielleadams pushed a commit that referenced this pull request

Aug 16, 2022 
V8 APIs like HostImportModuleDynamicallyCallback and
ScriptCompiler::CompileFunction is moving away from ScriptOrModule.

Replaces ScriptCompiler::CompileFunctionInContext with
ScriptCompiler::CompileFunction to remove the usages on the optional
out param ScriptOrModule.

PR-URL: #44198
Fixes: nodejs/node-v8#214
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

ruyadorno pushed a commit that referenced this pull request

Aug 23, 2022 
V8 APIs like HostImportModuleDynamicallyCallback and
ScriptCompiler::CompileFunction is moving away from ScriptOrModule.

Replaces ScriptCompiler::CompileFunctionInContext with
ScriptCompiler::CompileFunction to remove the usages on the optional
out param ScriptOrModule.

PR-URL: #44198
Fixes: nodejs/node-v8#214
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Fyko pushed a commit to Fyko/node that referenced this pull request

Sep 15, 2022 
V8 APIs like HostImportModuleDynamicallyCallback and
ScriptCompiler::CompileFunction is moving away from ScriptOrModule.

Replaces ScriptCompiler::CompileFunctionInContext with
ScriptCompiler::CompileFunction to remove the usages on the optional
out param ScriptOrModule.

PR-URL: nodejs#44198
Fixes: nodejs/node-v8#214
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

legendecas added a commit to legendecas/node that referenced this pull request

Nov 7, 2023 
Usages of `v8::ScriptOrModule` were removed in nodejs#44198
so the flag can be disabled by default.

nodejs-github-bot pushed a commit that referenced this pull request

Nov 17, 2023 
Usages of `v8::ScriptOrModule` were removed in #44198
so the flag can be disabled by default.

PR-URL: #50616
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

targos pushed a commit that referenced this pull request

Nov 23, 2023 
Usages of `v8::ScriptOrModule` were removed in #44198
so the flag can be disabled by default.

PR-URL: #50616
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

martenrichter pushed a commit to martenrichter/node that referenced this pull request

Nov 26, 2023 
Usages of `v8::ScriptOrModule` were removed in nodejs#44198
so the flag can be disabled by default.

PR-URL: nodejs#50616
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

lucshi pushed a commit to lucshi/node that referenced this pull request

Nov 27, 2023 
Usages of `v8::ScriptOrModule` were removed in nodejs#44198
so the flag can be disabled by default.

PR-URL: nodejs#50616
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

RafaelGSS pushed a commit that referenced this pull request

Nov 29, 2023 
Usages of `v8::ScriptOrModule` were removed in #44198
so the flag can be disabled by default.

PR-URL: #50616
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

RafaelGSS pushed a commit that referenced this pull request

Nov 30, 2023 
Usages of `v8::ScriptOrModule` were removed in #44198
so the flag can be disabled by default.

PR-URL: #50616
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

UlisesGascon pushed a commit that referenced this pull request

Dec 11, 2023 
Usages of `v8::ScriptOrModule` were removed in #44198
so the flag can be disabled by default.

PR-URL: #50616
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

UlisesGascon pushed a commit that referenced this pull request

Dec 19, 2023 
Usages of `v8::ScriptOrModule` were removed in #44198
so the flag can be disabled by default.

PR-URL: #50616
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>