tools: fix installing node with shared mode by zcbenz · Pull Request #51910

tools: fix installing node with shared mode by zcbenz · Pull Request #51910 · nodejs/node

Fix a bug caused by nodejs#50737 that,
make install fails for --shared mode.

added build

Issues and PRs related to build files or the CI.

needs-ci

PRs that need a full CI run.

python

PRs and issues that require attention from people who are familiar with Python.

labels

Feb 28, 2024

richardlau added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 28, 2024

marco-ippolito pushed a commit that referenced this pull request

Mar 1, 2024

Fix a bug caused by #50737 that,
make install fails for --shared mode.

PR-URL: #51910
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

Mar 1, 2024

Fix a bug caused by #50737 that,
make install fails for --shared mode.

PR-URL: #51910
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

richardlau pushed a commit that referenced this pull request

Mar 25, 2024

Fix a bug caused by #50737 that,
make install fails for --shared mode.

PR-URL: #51910
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

richardlau pushed a commit that referenced this pull request

Mar 25, 2024

Fix a bug caused by #50737 that,
make install fails for --shared mode.

PR-URL: #51910
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request

Mar 26, 2024

Fix a bug caused by nodejs#50737 that,
make install fails for --shared mode.

PR-URL: nodejs#51910
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>