build,tools: make addons tests work with GN by zcbenz · Pull Request #50737

build,tools: make addons tests work with GN by zcbenz · Pull Request #50737 · nodejs/node

added build

Issues and PRs related to build files or the CI.

dependencies

Pull requests that update a dependency file.

libuv

Issues and PRs related to the libuv dependency or the uv binding.

needs-ci

PRs that need a full CI run.

openssl

Issues and PRs related to the OpenSSL dependency.

python

PRs and issues that require attention from people who are familiar with Python.

tools

Issues and PRs related to the tools directory.

windows

Issues and PRs related to the Windows platform.

labels

Nov 15, 2023

zcbenz deleted the build-addons-gn branch

February 23, 2024 07:17

marco-ippolito pushed a commit that referenced this pull request

Feb 26, 2024

PR-URL: #50737
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>

marco-ippolito pushed a commit that referenced this pull request

Feb 26, 2024

PR-URL: #50737
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>

marco-ippolito pushed a commit that referenced this pull request

Feb 27, 2024

PR-URL: #50737
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>

zcbenz added a commit to zcbenz/node that referenced this pull request

Feb 28, 2024

Fix a bug caused by nodejs#50737 that,
make install fails for --shared mode.

nodejs-github-bot pushed a commit that referenced this pull request

Mar 1, 2024

Fix a bug caused by #50737 that,
make install fails for --shared mode.

PR-URL: #51910
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

Mar 1, 2024

Fix a bug caused by #50737 that,
make install fails for --shared mode.

PR-URL: #51910
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

Mar 1, 2024

Fix a bug caused by #50737 that,
make install fails for --shared mode.

PR-URL: #51910
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

zcbenz pushed a commit to photoionization/node_ci that referenced this pull request

Mar 6, 2024

- Use node in-tree gn configs when possible.
  Some in-tree configs (deps/openssl) were modified in our mirror until
  they are fixed in the upstream node repo [1].
- Trigger landmine to clean out directory (required due to changed
  targets with new build files)
- Update to node-ci-2024-01-17
- Add fp16 to update_deps.py

[1] nodejs/node#50737.

Bug: v8:14572

Change-Id: I86cc19d23151b2a64d7173cf8f0aa6adc417c091
Reviewed-on: https://chromium-review.googlesource.com/c/v8/node-ci/+/5203209
Commit-Queue: Patrick Thier <pthier@chromium.org>
Reviewed-by: Victor Gomes <victorgomes@chromium.org>

richardlau pushed a commit that referenced this pull request

Mar 25, 2024

PR-URL: #50737
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>

richardlau pushed a commit that referenced this pull request

Mar 25, 2024

Fix a bug caused by #50737 that,
make install fails for --shared mode.

PR-URL: #51910
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

richardlau pushed a commit that referenced this pull request

Mar 25, 2024

PR-URL: #50737
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>

richardlau pushed a commit that referenced this pull request

Mar 25, 2024

Fix a bug caused by #50737 that,
make install fails for --shared mode.

PR-URL: #51910
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request

Mar 26, 2024

PR-URL: nodejs#50737
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request

Mar 26, 2024

Fix a bug caused by nodejs#50737 that,
make install fails for --shared mode.

PR-URL: nodejs#51910
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>