Home Original page

benchmark: add ipc support to benchmark spawn stdio config by thisalihassan · Pull Request #52456 · nodejs/node

@thisalihassan 

Enabled inter-process communication (ipc) in the stdio configuration
of the spawn function within the benchmark subsystem.
This change allows for improved data exchange between parent
and benchmarked child processes, addressing limitations in performance
testing scenarios.

Fixes: nodejs#52233
Refs: nodejs/performance#161

@nodejs-github-bot added benchmark

Issues and PRs related to the benchmark subsystem.

performance

Issues and PRs related to the performance of Node.js.

labels

Apr 10, 2024

@thisalihassan

mcollina

rluvaton

@rluvaton rluvaton added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 11, 2024

nodejs-github-bot pushed a commit that referenced this pull request

Apr 13, 2024 
Enabled inter-process communication (ipc) in the stdio configuration
of the spawn function within the benchmark subsystem.
This change allows for improved data exchange between parent
and benchmarked child processes, addressing limitations in performance
testing scenarios.

Fixes: #52233
Refs: nodejs/performance#161
PR-URL: #52456
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>

aduh95 pushed a commit that referenced this pull request

Apr 29, 2024 
Enabled inter-process communication (ipc) in the stdio configuration
of the spawn function within the benchmark subsystem.
This change allows for improved data exchange between parent
and benchmarked child processes, addressing limitations in performance
testing scenarios.

Fixes: #52233
Refs: nodejs/performance#161
PR-URL: #52456
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>

aduh95 pushed a commit that referenced this pull request

Apr 29, 2024

marco-ippolito pushed a commit that referenced this pull request

May 2, 2024 
Enabled inter-process communication (ipc) in the stdio configuration
of the spawn function within the benchmark subsystem.
This change allows for improved data exchange between parent
and benchmarked child processes, addressing limitations in performance
testing scenarios.

Fixes: #52233
Refs: nodejs/performance#161
PR-URL: #52456
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

May 3, 2024 
Enabled inter-process communication (ipc) in the stdio configuration
of the spawn function within the benchmark subsystem.
This change allows for improved data exchange between parent
and benchmarked child processes, addressing limitations in performance
testing scenarios.

Fixes: #52233
Refs: nodejs/performance#161
PR-URL: #52456
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>