remove CPUSET due to a it not working as we see a lot of NaN in the results by rluvaton · Pull Request #161 · nodejs/performance

@rluvaton

anonrig

approved these changes Apr 10, 2024

thisalihassan added a commit to thisalihassan/node that referenced this pull request

Apr 10, 2024
Enabled inter-process communication (ipc) in the stdio configuration
of the spawn function within the benchmark subsystem.
This change allows for improved data exchange between parent
and benchmarked child processes, addressing limitations in performance
testing scenarios.

Fixes: nodejs#52233
Refs: nodejs/performance#161

nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request

Apr 13, 2024
Enabled inter-process communication (ipc) in the stdio configuration
of the spawn function within the benchmark subsystem.
This change allows for improved data exchange between parent
and benchmarked child processes, addressing limitations in performance
testing scenarios.

Fixes: #52233
Refs: nodejs/performance#161
PR-URL: #52456
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>

aduh95 pushed a commit to nodejs/node that referenced this pull request

Apr 29, 2024
Enabled inter-process communication (ipc) in the stdio configuration
of the spawn function within the benchmark subsystem.
This change allows for improved data exchange between parent
and benchmarked child processes, addressing limitations in performance
testing scenarios.

Fixes: #52233
Refs: nodejs/performance#161
PR-URL: #52456
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>

aduh95 pushed a commit to nodejs/node that referenced this pull request

Apr 29, 2024

marco-ippolito pushed a commit to nodejs/node that referenced this pull request

May 2, 2024
Enabled inter-process communication (ipc) in the stdio configuration
of the spawn function within the benchmark subsystem.
This change allows for improved data exchange between parent
and benchmarked child processes, addressing limitations in performance
testing scenarios.

Fixes: #52233
Refs: nodejs/performance#161
PR-URL: #52456
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>

marco-ippolito pushed a commit to nodejs/node that referenced this pull request

May 2, 2024

marco-ippolito pushed a commit to nodejs/node that referenced this pull request

May 3, 2024
Enabled inter-process communication (ipc) in the stdio configuration
of the spawn function within the benchmark subsystem.
This change allows for improved data exchange between parent
and benchmarked child processes, addressing limitations in performance
testing scenarios.

Fixes: #52233
Refs: nodejs/performance#161
PR-URL: #52456
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>

marco-ippolito pushed a commit to nodejs/node that referenced this pull request

May 3, 2024